search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
1.99k stars 1.16k forks source link

[Monitor Exporter] Fix ESLint errors #17942

Open jeremymeng opened 2 years ago

jeremymeng commented 2 years ago

Fix lint errors found in the @azure/monitor-opentelemetry-exporter package by ESLint. Following are the steps to run ESLint for this package and reproduce this issue.

  1. Set up your dev environment if not already done so as mentioned here
  2. Go to <repo root>/sdk/monitor/monitor-opentelemetry-exporter
  3. run rushx lint
  4. Command in step 2 generates an html report in directory <repo root>/monitor/monitor-opentelemetry-exporter with name ends with lintReport.html
  5. All lint errors found in this package is listed on html report.

Once all known issues are resolved, below change is required in package.json file in package root `/sdk/monitor/monitor-opentelemetry-exporter to treat any new lint regression as hard failure in CI.

jeremymeng commented 2 years ago

But I would like to understand if you just need to remove this lint script in the package.json file?

Thanks @glaucia86! We'd want to fix all the linter errors in this package first, then remove just the last part of the lint NPM script. Let me know if you have additional questions.

glaucia86 commented 2 years ago

I got it, @jeremymeng! So, in this case change this lint script to this way, right?"

"lint": "eslint package.json api-extractor.json src test --ext .ts"

Because this part of the script:

 -f html -o telemetry-exporter-lintReport.html || exit 0 

it is just the part of the script result to send the html file report, right? I'll fork this project and then try to figure it out the linter errors in this package.json file first.

github-actions[bot] commented 4 months ago

Hi @jeremymeng, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.