search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.07k stars 1.19k forks source link

Azure MySQL example is incorrect #19942

Closed AlphaWong closed 2 years ago

AlphaWong commented 2 years ago

mysql2 example is incorrect

const mysql = require('mysql2');

const connection = mysql.createConnection({
  host: 'mysqldemo.mysql.database.azure.com',
  user: 'myadmin@mysqldemo',
  password: 'your_password',
  database: 'my_db',
  port: 3306,
  ssl: true <--- this line is wrong, it only accepte object instead of boolean 
});

reference: https://github.com/sidorares/node-mysql2/blob/master/documentation/Examples.md#connecting-over-encrypted-connection

[Enter feedback here]

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ajlam commented 2 years ago

Tagging @mksuni and @savjani

savjani commented 2 years ago

Adding @shreyaaithal to help as well

shreyaaithal commented 2 years ago

Hi @AlphaWong , thanks for calling this out. The reference example has been corrected.

ghost commented 2 years ago

Hi @AlphaWong. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.