search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.06k stars 1.19k forks source link

Storage-blob: Docs issue when using SAS token #22402

Open adedayotoheeb opened 2 years ago

adedayotoheeb commented 2 years ago

The documentation for connecting to Azure Blob Storage using the SAS TOKEN is wrong. Below is the current implementation:

const { BlobServiceClient } = require("@azure/storage-blob");

const account = ""; const sas = "";

const blobServiceClient = new BlobServiceClient(https://${account}.blob.core.windows.net${sas});

The correct implementation should be:

const { BlobServiceClient } = require("@azure/storage-blob");

const account = ""; const sas = "";

const blobServiceClient = new BlobServiceClient(https://${account}.blob.core.windows.net?${sas});

There should be a ? before the sas token.

EmmaZhu commented 2 years ago

@adedayotoheeb

Thanks a lot for reporting this to us. We'll update the document.

Thanks Emma

github-actions[bot] commented 3 months ago

Hi @adedayotoheeb, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.