search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.03k stars 1.19k forks source link

Dependency package @typescript-eslint/typescript-estree has a new version available #22701

Open azure-sdk opened 2 years ago

azure-sdk commented 2 years ago

We have identified a dependency on version 8.2.0 of @typescript-eslint/typescript-estree. A new version (8.5.0) is available for upgrade.

Following are the steps to upgrade package dependency.

  1. Understand the breaking changes between the version being used and the version you want to upgrade to.

  2. Identify all packages that take a dependency on this package.

  3. Go to the root folder for each such package (/sdk/service-name/package-name) and update package.json to have the new version.

  4. Run rush update to ensure the new version is pulled in.

  5. Make relevant changes to absorb the breaking changes.

  6. Repeat steps 3 to 5 for each of the packages that have a dependency on this package.

azure-sdk commented 2 years ago

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Azure.Core:0.3751404,Service Bus:0.19223258,EngSys:0.036430296'

deyaaeldeen commented 2 years ago

The problem with the linter packages is that they could have breaking changes between minor versions, which could be annoying to fix in automatic rush update --full PRs. Perhaps we could relax this upgrade requirement for linter packages? it is not super important to stay on latest and they shouldn't cause security vulnerabilities AFAICT. /cc @jeremymeng @xirzec

jeremymeng commented 2 years ago

yeah, I am thinking about just parking these work items as lower priority and upgrade @typescript-eslint dependencies less frequently.