search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.09k stars 1.21k forks source link

[engsys] remove `namedExports` option from rollup commonjs plugin argument. #23284

Closed jeremymeng closed 1 year ago

jeremymeng commented 2 years ago

We have a couple of files that still passing namedExports to cjs(). The latest version of @rollup/plugin-commonjs no longer needs this and can figure out automatically. We should not need to pass it now.

Example in current code base:

    cjs({
      namedExports: {
        chai: ["should", "assert"],
        assert: ["equal", "deepEqual", "notEqual"],
      },
    }),

which can be updated to be just

    cjs(),
deyaaeldeen commented 1 year ago

We no longer do that: https://github.com/Azure/azure-sdk-for-js/blob/48a96a7db8de47870f2ff18904e3d042b19db9d1/common/tools/dev-tool/src/commands/run/bundle.ts#L108-L113