Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.02k stars 1.19k forks source link

[ARM] Migrate tests to use recorder v2 instead of v1 #23567

Closed HarshaNalluru closed 1 year ago

HarshaNalluru commented 1 year ago

We have an ongoing effort of moving recordings for all the tests out of the JS repository to the assets repo. For that, each of the packages have to be on recorder v2.

"@azure-tools/test-recorder": "^1.0.0" in package.json 

./sdk/**/arm-*/package.json  -> 111 packages

So, 111 arm packages depend on recorder v1.

Most of them look like dummy test files.

image
azure-sdk commented 1 year ago

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Azure.Core:0.24526887,EngSys:0.14073716,Cognitive - Form Recognizer:0.097520426'

MaryGao commented 1 year ago

@HarshaNalluru I have an rough estimation, there are

I think for the generated dummy files we could have a script to exec the steps in upgrading to v2 gist . However for the manual maintained test files we need to fix them one by one.

I could work on the script to upgrade the dummy files and I'd like to confirm with things with you:

HarshaNalluru commented 1 year ago

Thanks, @MaryGao, for the estimates. The GIST looks perfect, we can move forward with the plan.

Do you have a suggested priority or deadline for the issue?

Optimistically, before the end of November, we should finish the migration for all.

Considering we have around 40 files to change manually, could you work with me together to fix them?

For sure, can definitely share the work and fix them.

MaryGao commented 1 year ago

@kazrael2119 Could you share the status of refreshing the package?

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 11/14:

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 11/17:

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 11/18:

@azure/arm-changeanalysis @azure/arm-changes link:https://github.com/Azure/azure-sdk-for-js/pull/23888

@azure/arm-billing @azure/arm-botservice link:https://github.com/Azure/azure-sdk-for-js/pull/23884

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 11/23:

@azure/arm-confluent @azure/arm-containerregistry @azure/arm-customerinsights link:https://github.com/Azure/azure-sdk-for-js/pull/23905

@azure/arm-deploymentmanager @azure/arm-desktopvirtualization @azure/arm-devspaces @azure/arm-devtestlabs link:https://github.com/Azure/azure-sdk-for-js/pull/23937

@azure/arm-dns @azure/arm-domainservices @azure/arm-eventhub link:https://github.com/Azure/azure-sdk-for-js/pull/23954

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 11/28:

@azure/arm-features @azure/arm-locks @azure/arm-policy @azure/arm-links @azure/arm-managedapplications @azure/arm-templatespecs @azure/arm-resources-subscriptions link:https://github.com/Azure/azure-sdk-for-js/pull/23959

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 11/29:

@azure/arm-databox @azure/arm-databoxedge @azure/arm-databricks link:https://github.com/Azure/azure-sdk-for-js/pull/23917

@azure/arm-datacatalog @azure/arm-datadog @azure/arm-datamigration link:https://github.com/Azure/azure-sdk-for-js/pull/23929

@azure/arm-frontdoor @azure/arm-hanaonazure link:https://github.com/Azure/azure-sdk-for-js/pull/23961

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 11/30:

@azure/arm-healthbot @azure/arm-healthcareapis @azure/arm-hybridcompute @azure/arm-hybridkubernetes link:https://github.com/Azure/azure-sdk-for-js/pull/23999

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 12/02

@azure/arm-iotcentral @azure/arm-keyvault @azure/arm-kubernetesconfiguration link:https://github.com/Azure/azure-sdk-for-js/pull/24004

@azure/arm-commitmentplans @azure/arm-webservices @azure/arm-workspaces @azure/arm-machinelearning link:https://github.com/Azure/azure-sdk-for-js/pull/24006

@azure/arm-machinelearningcompute @azure/arm-managementgroups @azure/arm-maps @azure/arm-mariadb link:https://github.com/Azure/azure-sdk-for-js/pull/24038

@azure/arm-operationsmanagement @azure/arm-peering @azure/arm-postgresql @azure/arm-powerbiembedded link:https://github.com/Azure/azure-sdk-for-js/pull/24082

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 12/05

@azure/arm-privatedns @azure/arm-purview @azure/arm-quota link:https://github.com/Azure/azure-sdk-for-js/pull/24089

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 12/06

@azure/arm-mixedreality @azure/arm-mysql @azure/arm-notificationhubs @azure/arm-oep link:https://github.com/Azure/azure-sdk-for-js/pull/24072

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 12/09

@azure/arm-commerce:https://github.com/Azure/azure-sdk-for-js/pull/23902

HarshaNalluru commented 1 year ago

Thanks, @kazrael2119, for the progress. 💚 It's great to see the packages being onboarded to recorder v2.

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 12/12:

@azure/arm-recoveryservicesbackup https://github.com/Azure/azure-sdk-for-js/pull/24118

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 12/13:

@azure/arm-resourcemover https://github.com/Azure/azure-sdk-for-js/pull/24155

@azure/arm-datalake https://github.com/Azure/azure-sdk-for-js/pull/23969

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 12/14

@azure/arm-hardwaresecuritymodules https://github.com/Azure/azure-sdk-for-js/pull/24008

@azure/arm-redisenterprise @azure/arm-resourcegraph @azure/arm-serialconsole @azure/arm-servicebus https://github.com/Azure/azure-sdk-for-js/pull/24153

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 12/16

@azure/arm-sql https://github.com/Azure/azure-sdk-for-js/pull/24198

@azure/arm-timeseriesinsights https://github.com/Azure/azure-sdk-for-js/pull/24219

@azure/arm-streamanalytics @azure/arm-videoanalyzer @azure/arm-visualstudio https://github.com/Azure/azure-sdk-for-js/pull/24210

@azure/arm-servicefabric @azure/arm-servicelinker @azure/arm-storagesync @azure/arm-storsimple1200series @azure/arm-storsimple8000series https://github.com/Azure/azure-sdk-for-js/pull/24196

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 12/20: @azure/arm-synapse https://github.com/Azure/azure-sdk-for-js/pull/24212

@azure/arm-search https://github.com/Azure/azure-sdk-for-js/pull/24182

@azure/arm-cdn https://github.com/Azure/azure-sdk-for-js/pull/23887

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 12/21:

@azure/arm-appservice-profile-2020-09-01-hybrid @azure/arm-authorization-profile-2020-09-01-hybrid @azure/arm-commerce-profile-2020-09-01-hybrid @azure/arm-compute-profile-2020-09-01-hybrid https://github.com/Azure/azure-sdk-for-js/pull/24246

@azure/arm-databoxedge-profile-2020-09-01-hybrid @azure/arm-dns-profile-2020-09-01-hybrid @azure/arm-eventhub-profile-2020-09-01-hybrid @azure/arm-iothub-2020-09-01-hybrid https://github.com/Azure/azure-sdk-for-js/pull/24286

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 12/22:

@azure/arm-locks-profile-2020-09-01-hybrid @azure/arm-keyvault-profile-2020-09-01-hybrid @azure/arm-monitor-profile-2020-09-01-hybrid @azure/arm-mysql-flexible https://github.com/Azure/azure-sdk-for-js/pull/24302

kazrael2119 commented 1 year ago

The libs are upgraded to recorder v2 at 12/23:

@azure/arm-network-profile-2020-09-01-hybrid @azure/arm-policy-profile-2020-09-01-hybrid @azure/arm-postgresql-flexible @azure/arm-resources-2020-09-01-hybrid @azure/arm-subscription-2020-09-01-hybrid @azure/arm-storage-2020-09-01-hybrid https://github.com/Azure/azure-sdk-for-js/pull/24318

@azure/arm-servicemap https://github.com/Azure/azure-sdk-for-js/pull/24270

kazrael2119 commented 1 year ago

Hi @HarshaNalluru ,all mgmt packages are refreshed ,can we close this issue?

HarshaNalluru commented 1 year ago

Yes, thanks a ton @kazrael2119 🎉