search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.06k stars 1.19k forks source link

Runtime version variables come null. Have they been deprecated and replaced with linuxFxVersion and windowsFxVersion? #26881

Open akumar-99 opened 1 year ago

akumar-99 commented 1 year ago

Describe the bug

"netFrameworkVersion": null,
"phpVersion": null,
"pythonVersion": null,
"nodeVersion": null,
"powerShellVersion": null,
"linuxFxVersion": "PYTHON|3.10",
"windowsFxVersion": null,

I have a Web App running on Code - Python 3.10 runtime but when I see the value on UI JSON or fetch using CLI or JS SDK or REST API, pythonVersion comes as null whereas it should have been 3.10 but linuxFxVersion reports the right value which also matches with the list produced from CLI command az webapp list-runtimes.

To Reproduce Steps to reproduce the behavior:

  1. Create a Web App - Code and Configure your Stack Runtime.
  2. Visit the overview page and open JSON view.
  3. Check using az webapp CLI command.

Expected behavior According to stack configuration, appropriate runtime variable should return value instead of null.

Screenshots Web App Stack Runtime Configuration on Configuration PageWeb App Stack Runtime Configuration on Configuration Page
Web App Stack Runtime Configuration on Overview PageWeb App Stack Runtime Configuration on Overview Page
UI JSONUI JSON

Additional context Add any other context about the problem here.

qiaozha commented 1 year ago

If I understand correctly, CLI is parsing the value from runtime majorVersions or minorVersions. https://github.com/Azure/azure-cli/blob/56d778e6ff2f6032ea47eb63727fa1308a390d76/src/azure-cli/azure/cli/command_modules/appservice/custom.py#L3166-L3173 https://github.com/Azure/azure-cli/blob/56d778e6ff2f6032ea47eb63727fa1308a390d76/src/azure-cli/azure/cli/command_modules/appservice/custom.py#L3314-L3365 which is hard coded in Azure CLI.

github-actions[bot] commented 1 year ago

Hi @akumar-99. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

akumar-99 commented 1 year ago

Something from my personal notes will help.

akumar-99 commented 1 year ago

@qiaozha So according to this then https://github.com/Azure/azure-cli/blob/56d778e6ff2f6032ea47eb63727fa1308a390d76/src/azure-cli/azure/cli/command_modules/appservice/custom.py#L3165 the null and "" values are by design?

Please elaborate further on major, minor versions parsing.

qiaozha commented 1 year ago

do you see any majorVersions or minorVersions informations when using client.provider.listWebAppStacks() apis ? I can not tell from your earlier screenshot.

akumar-99 commented 1 year ago

No, there are no fields related to majorVersions or minorVersions in the outputs. I have used appServiceClient.webApps.list() and appServiceClient.webApps.getConfiguration(resourceGroupName,webAppName) and neither has these two fields.

Cestmoileo commented 6 months ago

My issue might be the same, i have 2 app services, one runs on linux another one runs on windows . The properties.siteConfig.WindowsFxVersion --- for the app service which runs on windows OS returns null value , not sure what is wrong , but correctly populated for the app service which runs on linux OS

can someone send me insights on this , please

image

Cestmoileo commented 6 months ago

@qiaozha can you send some insights on my issue, thx ..