Open lmolkova opened 11 months ago
@lmolkova hi! Any concerns about breaking changes / should we populate both or just rename the existing attributes? Just wanted to double check 👍
cc @hectorhdzg since appInsights uses our tracer - @hectorhdzg any concerns about renaming these attributes or do we need to keep both for backwards compat?
We did breaking change on .NET and Java - given that plugins are experimental, we can do it. Still curious what @hectorhdzg would say :)
@maorleger JS OTel is currently working on supporting new semconv, work is being tracked here, currently exporters do not support latest semantic convention, including Azure Monitor one, I will sync with Java/.NET folks but I suppose they have code to support backward compatibly attributes, so maybe it makes sense to hold this one for a few, until exporters have support for it.
.NET exporter supports all new semconv attributes https://github.com/Azure/azure-sdk-for-net/blob/fe7a2ec767b968f13c544e1ac902e299d0022639/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/Vendoring/Shared/SemanticConventions.cs#L106
@hectorhdzg is there an issue for @azure/monitor-opentelemetry-exporter we can track to know when it's done? The one you linked is for JS HTTP client instrumentations.
@lmolkova Created following issue to track on exporter side, we are waiting for @opentelemetry/semantic-conventions to have latest attributes, we will update when they are available.
Update HTTP attributes to comply with HTTP semconv vTBD (likely 1.23.0 will declare them as stable):
http.method
->http.request.method
http.status_code
->http.response.status_code
net.peer.name
->server.address
net.peer.port
->server.port
http.url
->url.full
http.user_agent
->user_agent.original
error.type
- some error-code or a full exception name if exception happens. Also includes status code (as string) for responses we consider to be an error. Maybe we can steal something from .NET - https://github.com/dotnet/runtime/blob/main/src/libraries/System.Net.Http/src/System/Net/Http/Metrics/MetricsHandler.cs#L157http.request.resend_count
- try count