search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.05k stars 1.19k forks source link

[monitor-opentelemetry-exporter] Adopt OpenTelemetry HTTP semconv 1.23.1 #29033

Open hectorhdzg opened 6 months ago

hectorhdzg commented 6 months ago

https://opentelemetry.io/blog/2023/http-conventions-declared-stable/

github-actions[bot] commented 6 months ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @cijothomas @rajkumar-rangaraj @ramthi @reyang @TimothyMothra @vishweshbankwar.

TimothyMothra commented 6 months ago

@hectorhdzg, can you investigate why the .NET crew is getting assigned to JS issues? :)

hectorhdzg commented 6 months ago

@TimothyMothra sounds like a github-actions misconfiguration, :) I was going to ask you guys the same thing. Let me see if I find some reference.

TimothyMothra commented 6 months ago

This looks sus: https://github.com/Azure/azure-sdk-for-js/blob/37e3efd7bf2c29c6e6247a1d35fea6988989f38c/.github/CODEOWNERS#L1211-L1212

hectorhdzg commented 6 months ago

@TimothyMothra that text is apparently is commented out, so not sure why this is triggering, @xirzec any idea about this?, I can update owners there if this is by design.

xirzec commented 4 months ago

@hectorhdzg I agree with @TimothyMothra that it is "sus". The double @ is odd and the owners don't seem correct. I'd also think we should tie this to the actual directory path, rather than being a <NotInRepo> comment:

/sdk/monitor/monitor-opentelemetry-exporter @hectorhdzg @JacksonWeber

Feel free to PR an update and I will approve!

hectorhdzg commented 4 months ago

@xirzec created following PR