Post core-esm migration - Migrate `test-utils`

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.

MIT License

2.06k stars 1.19k forks source link

Post core-esm migration - Migrate `test-utils` #29287

Closed HarshaNalluru closed 1 month ago

HarshaNalluru commented 5 months ago

This issue is to track the work involved in migrating test-utils.

chai globals/namespaces are involved, which need to be migrated to vitest
mockInstrumenter may need to be modified
changes similar to @azure/core-tracing maybe needed (cc @jeremymeng )
or make a new major version like the recorder v3 -> v4 to capture the differences of cjs vs esm

@maorleger Standalone, the tracing test at template fails with the following.. from the PR #29016

maorleger commented 5 months ago

I won't have bandwidth to look at this for a while, so if there's urgency Matt said he might take a stab at it next week. Worse case scenario maybe we can switch that test to a mocking approach?

The only thing I can think of is that dual-package hazard issue combined with side-by-side versions of core-tracing 🤷

I don't know about the rest of the items on the list

deyaaeldeen commented 1 month ago

@mpodwysocki added test-utils-vitest which addresses this issue. An example for using it can be found in https://github.com/Azure/azure-sdk-for-js/pull/30760