search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.03k stars 1.19k forks source link

AzurePipelinesCredential: clarify system access token requirement #29591

Closed chlowell closed 2 months ago

chlowell commented 4 months ago

Currently the credential requires users to provide the system access token via the environment variable SYSTEM_ACCESSTOKEN. Users must configure their pipelines to set this variable because AzDO doesn't do so automatically. We must at least document this requirement. We should also consider taking the system access token as a constructor argument rather than an environment variable. Doing that would make the value obviously required and make the credential's configuration API consistent in that every configuration parameter required from the application would be a constructor argument.

AisseMTT commented 3 months ago

Can we also add documentation for how to set the SYSTEM_ACCESSTOKEN in AzDO? @chlowell perhaps you have some documentation for how to do this?

chlowell commented 3 months ago

👍 there's a YAML example in the Pipelines documentation

KarishmaGhiya commented 2 months ago

This was completed with the last release - https://github.com/Azure/azure-sdk-for-js/pull/29854