search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.06k stars 1.19k forks source link

Should we have a dedicate repo for samples and only update the commit id in SDK repo? #30155

Open qiaozha opened 3 months ago

qiaozha commented 3 months ago

Currently, we put all the generated/manual written samples into the SDK repo, and the mgmt plane SDK release PR becomes a huge PR most of time even for a minor version bump change. like hundreds or thousands of file changes.

I wonder if we do something similar like test recording. to have a dedicate repo and SDK repo just update the commit id there?

We used to have manual written mgmt JS samples in this repo https://github.com/Azure-Samples/azure-sdk-for-js-samples. maybe we can put the samples there?

I guess we need to change a lot of the current pipeline related scripts, and probably need to make sure the sample build can work before publish the samples.

One another concern is that I rememebr the manual written samples will be published to mslearn, but auto generated sample won't. https://learn.microsoft.com/en-us/samples/browse/?languages=javascript%2Ctypescript

xirzec commented 3 months ago

I'm open to this idea, though it appears to affect all languages (e.g. here's a C# review with a bunch of samples touched: https://github.com/Azure/azure-sdk-for-net/pull/44547/files#diff-5c6bb66656c182be900f60e7beca64b9e14e64d5bb9757874d504398cbfdd316) so we should solve this for everyone rather than only for JS.