search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.03k stars 1.19k forks source link

Bulk API - continueOnError default to false still after 4.0 release #30884

Open akcyp opened 3 weeks ago

akcyp commented 3 weeks ago

The JSDoc comment posted above the implementation of the "bulk" operation is incorrect / outdated, which makes it misleading when using continueOnError.

[!NOTE] NOTE: THIS WILL DEFAULT TO TRUE IN THE 4.0 RELEASE

https://github.com/Azure/azure-sdk-for-js/blob/b459849a11811c4e0dbf214bd7cea2abff5e12b2/sdk/cosmosdb/cosmos/src/client/Item/Items.ts#L463

https://github.com/Azure/azure-sdk-for-js/blob/b459849a11811c4e0dbf214bd7cea2abff5e12b2//sdk/cosmosdb/cosmos/src/ClientContext.ts#L844

github-actions[bot] commented 3 weeks ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @sajeetharan @simorenoh.

sajeetharan commented 3 weeks ago

@akcyp thanks for reporting the issue, we will investigate and come back on this!