[core-rest-pipeline] NodeHttpClient didn't remove EventListener correctly caused MaxListenersExceededWarning

[MaryGao]

• Package Name: @azure/core-rest-pipeline
• Package Version: latest

Describe the bug See discussion. There are two issues

• we didn't wait the remove is done in finally https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/core/core-rest-pipeline/src/nodeHttpClient.ts#L181-L191
• isStreamComplete would always return un-resolved promise once stream is at the end already: https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/core/core-rest-pipeline/src/nodeHttpClient.ts#L29

How to reproduce:

• checkout pr https://github.com/Azure/azure-sdk-for-js/pull/31027
• revert core-rest-pipeline
• rush build -t @azure-rest/ai-translation-document && rushx unit-test:node
• you will see the MaxListenersExceededWarning

Expected behavior The above two would cause the removal action would not be called here.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

[github-actions[bot]]

@deyaaeldeen @jeremymeng @joheredi @maorleger @mpodwysocki @timovv @xirzec

[github-actions[bot]]

Thank you for your feedback. Tagging and routing to the team member best able to assist.

[mpodwysocki]

@MaryGao I'm trying to fix via https://github.com/Azure/azure-sdk-for-js/pull/31077

[jeremymeng]

@MaryGao I'm trying to fix via #31077

There's still the issue for an already completed stream? Those events will not be fired thus the promise not resolving.