search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.05k stars 1.19k forks source link

Allow certain response headers coming from AzurePipelinesCredential to be logged #31130

Open ahsonkhan opened 5 days ago

ahsonkhan commented 5 days ago

These two response headers are useful for the service team to debug and diagnose issues, and hence it is requested that we do log them.

We decided, other than logging them, to also add these header values to the exception message that is thrown, so they are always visible, even with logging disabled.

Given our logged headers are based on an allow list, currently these two headers are REDACTED.

https://github.com/Azure/azure-sdk-for-js/blob/9e8083e3fdae7cc0dfdb5b19c1f3f53631065e69/sdk/core/core-rest-pipeline/src/util/sanitizer.ts#L27-L70

ahsonkhan commented 1 day ago

See https://github.com/Azure/azure-sdk-for-cpp/pull/6001 for an example change from C++.