search

Azure / azure-sdk-for-js

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our public developer docs at https://docs.microsoft.com/javascript/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-js.
MIT License
2.07k stars 1.19k forks source link

azure-servicefabric does not support client certificate authentication #3720

Closed talarari closed 6 months ago

talarari commented 6 years ago

When connecting to a secure service fabric cluster a common way it to use client certificate to authenticate. this is supported by the sfctl cli tool by specifying a pem file path.

seems like the ServiceFabricClient class which extends ServiceClient does not receieve a ServiceClientCredentials in its constuctor and there is not implementation of ServiceClientCredentials for ClientCertificateAuthorization.

this is the equivalent implementation in python used by the sfctl cli tool: https://github.com/Azure/service-fabric-cli/blob/master/src/sfctl/auth.py#L13

kurtzeborn commented 5 years ago

Thank you for opening this issue! We are routing it to the appropriate team for follow up.

ramya-rao-a commented 4 years ago

@joheredi You were involved in the latest update to the @azure/servicefabric package in #6504. Any idea if something in the swagger file is stopping the ServiceFabricClient to take in AAD credentials? How does the client run without any authentication?

ghost commented 4 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @QingChenmsft, @vaishnavk, @juhacket.

ramya-rao-a commented 4 years ago

Adding Service Attention label if we need a follow up via swagger changes or an answer around whether or not AAD creds are required to authenticate.

joheredi commented 4 years ago

Unfortunately, we currently don't support Certificate Authentication. This needs to be implemented in core-http to allow users to pass the certificate to establish the HTTP connection.

@ramya-rao-a I see that this is already marked as a Feature Request, I'll set milestone to backlog to give it visibility during planning.

xirzec commented 3 years ago

This should be doable in coreV2

github-actions[bot] commented 6 months ago

Hi @talarari, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.