search

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.23k stars 4.58k forks source link

Necessity of RunFilterParameters in Microsoft.Azure.Management.DataFactory.ActivityRunsOperationsExtensions.QueryByPipelineRun #18999

Closed shhafiz closed 3 years ago

shhafiz commented 3 years ago

public static ActivityRunsQueryResponse QueryByPipelineRun(this IActivityRunsOperations operations, string resourceGroupName, string factoryName, string runId, RunFilterParameters filterParameters);

In the above signature, once we have a runId, shouldn't the filterParameters be redundant? As I understand, for a given resource, factory and runId, there will be exactly one response. The filterParameters don't seem to serve any purpose. In fact it can be a source of error when the parameter does not match the runId attributes.

jsquire commented 3 years ago

Thank you for your feedback. Tagging and routing to the team member best able to assist.

nisha-bhatia commented 3 years ago

Thank you for your question, re-routing to a team member to assist.

ghost commented 3 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @shawnxzq, @lmy269.

Issue Details
`public static ActivityRunsQueryResponse QueryByPipelineRun(this IActivityRunsOperations operations, string resourceGroupName, string factoryName, string runId, RunFilterParameters filterParameters);` In the above signature, once we have a runId, shouldn't the filterParameters be redundant? As I understand, for a given resource, factory and runId, there will be exactly one response. The filterParameters don't seem to serve any purpose. In fact it can be a source of error when the parameter does not match the runId attributes.
Author: shhafiz
Assignees: allenjzhang
Labels: `Data Factory`, `Mgmt`, `Service Attention`, `customer-reported`, `needs-team-attention`, `question`
Milestone: -
shawnxzq commented 3 years ago

@LijuanZ Please help on this, thanks!

LijuanZ commented 3 years ago

@shhafiz @shawnxzq this is by design, note that it's to return ActivityRunsQueryResponse, this method is to list all activity runs for the provided pipeline run. The runId parameter is for pipeline run id, while the filterParameters is to provide further filters on activity runs. 1 pipeline run id is mapped to 1 pipeline run, but can contain multiple activity runs. Thanks!

shawnxzq commented 3 years ago

@nisha-bhatia Could you please help close this issue as I don't have permission? Thanks!

shawnxzq commented 3 years ago

@nisha-bhatia @jsquire Please help close this, thanks!