search

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.35k stars 4.71k forks source link

Add Schema Registry Performance Tests #21530

Closed g2vinay closed 9 months ago

g2vinay commented 3 years ago

Add Performance tests for the performance-critical champion scenarios of Schema Registry SDK.

Performance Test Writing Guidelines: https://github.com/Azure/azure-sdk-for-net/wiki/Writing-performance-tests-for-Client-libraries

pallavit commented 9 months ago

@jsquire , @m-redding please let me know if this issue can be closed.

m-redding commented 9 months ago

@pallavit do you know if there is still a goal to have perf tests for all services? Are there any guidelines as to which services should have them? This hasn't been done for Azure.Data.SchemaRegistry, but it has for Microsoft.Azure.Data.SchemaRegistry.ApacheAvro. If it should be done for Azure.Data.SchemaRegistry, I can work on this one.

pallavit commented 9 months ago

@m-redding I do see most of our HLCs having perf but I do not see that being propagated to DPG libraries. Do you see any perf sensitive scenarios for this SDK? If so, I do think there is merit in doing it. However if you don't think there are any such scenarios I would recommend closing it. Creating perf libraries w/o a specific perf sensitive scenarios seems like an overkill /cc: @jsquire

m-redding commented 9 months ago

There aren't any perf-sensitive scenarios part of Azure.Data.SchemaRegistry. All the APIs are just putting headers into responses with models. I'll close this one out.