search

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.47k stars 4.8k forks source link

Adding test setup in scenario tests for Azure SQL Advisors and Recommended Actions APIs #2250

Closed anilkyelam closed 7 years ago

anilkyelam commented 8 years ago

In Sql scenario tests, we are adding session records without any test setup. This will make it difficult for next developer to generate session records with similar responses for new versions of APIs.

See Mark's comment in pull request: https://github.com/Azure/azure-sdk-for-net/pull/2203 "You have json files, which indicate that you ran these tests against live azure. It looks like youi set up a bunch of Sql asssets in some subscription and then just ran list cmdlets against this setup. If this is the case, the next person who has to make a change here will have a great deal of difficulty in running these tests live for new recordings - they will basically have to either replicate exactly the setup you had live, or they will have to change the code.

If these changes are time sensitive, it is OK to check-in and add the test setup as part of the tests within the next month. If you want to do this, please file a bug for this in github, assign to yourself and reference it here."

jaredmoo commented 7 years ago

Test improvement for hyak-based client not needed because we are moving forward with autorest-based client. When advisors api is added to autorest-based client, the test will need to be fully automated before I sign off.