Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.17k stars 4.53k forks source link

[BUG] Null Reference Exception on calling SetAccessControlRecursiveAsync with Data Lake Client #22962

Closed nikhil-pandey closed 2 months ago

nikhil-pandey commented 2 years ago

Describe the bug SetAccessControlRecursiveAsync without providing optional options parameter throws Null Reference Exception.

Expected behavior It should use default options.

Actual behavior (include Exception or Stack Trace) Throws Null Reference exception on line https://github.com/Azure/azure-sdk-for-net/blob/598f9fe7cf8a14a32dab7a33b4b8c02247fd8340/sdk/storage/Azure.Storage.Files.DataLake/src/DataLakePathClient.cs#L2856

To Reproduce

  1. Call SetAccessControlRecursiveAsync without providing options for a directory that will return non-empty continuationToken
  2. The while loop on Line 2856 tries to access MaxBatches property from a null variable

Environment:

ghost commented 2 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @sumantmehtams.

Issue Details
**Describe the bug** `SetAccessControlRecursiveAsync` without providing optional `options` parameter throws Null Reference Exception. **Expected behavior** It should use default options. **Actual behavior (include Exception or Stack Trace)** Throws Null Reference exception on line https://github.com/Azure/azure-sdk-for-net/blob/598f9fe7cf8a14a32dab7a33b4b8c02247fd8340/sdk/storage/Azure.Storage.Files.DataLake/src/DataLakePathClient.cs#L2856 **To Reproduce** 1. Call `SetAccessControlRecursiveAsync` without providing options for a directory that will return non-empty `continuationToken` 2. The while loop on Line 2856 tries to access `MaxBatches` property from a null variable **Environment:** - Name and version of the Library package used: [e.g. Azure.Storage.Blobs 12.2.0] 12.6.2 - Hosting platform or OS and .NET runtime version (`dotnet --info` output for .NET Core projects): [e.g. Azure AppService or Windows 10 .NET Framework 4.8] netcoreapp3.1 - IDE and version : [e.g. Visual Studio 16.3] Rider 2021.1.5
Author: nikhil-pandey
Assignees: -
Labels: `Client`, `Data Lake Storage Gen2`, `Service Attention`, `customer-reported`, `needs-team-attention`, `needs-triage`, `question`
Milestone: -
github-actions[bot] commented 4 months ago

Hi @nikhil-pandey, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

github-actions[bot] commented 2 months ago

Hi @nikhil-pandey, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.