Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.17k stars 4.53k forks source link

[FEATURE REQ] Missing delete method in IWorkflowRunsOperations #26818

Closed vbossica closed 3 months ago

vbossica commented 2 years ago

Library name

Microsoft.Azure.Management.Logic

Please describe the feature.

There is an API endpoint to delete a workflow run, yet the method is missing in the IWorkflowRunsOperations methods

Would it be possible to add the missing method?

Or am I looking at the wrong place?

azure-sdk commented 2 years ago

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Logic App:0.5797381,EngSys:0.024003953,Data Factory:0.023453733'

jsquire commented 2 years ago

Thank you for your feedback. Tagging and routing to the team member best able to assist.

ghost commented 2 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/azure-logicapps-team.

Issue Details
### Library name Microsoft.Azure.Management.Logic ### Please describe the feature. There is an API endpoint to delete a [workflow run](https://docs.microsoft.com/en-us/rest/api/logic/workflow-runs/delete), yet the method is missing in the [IWorkflowRunsOperations methods](https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.management.logic.iworkflowrunsoperations?view=azure-dotnet) Would it be possible to add the missing method? Or am I looking at the wrong place?
Author: vbossica
Assignees: ArthurMa1978
Labels: `Logic App`, `Service Attention`, `Mgmt`, `question`, `needs-team-attention`
Milestone: -
ArthurMa1978 commented 2 years ago

@vbossica a running should be canceled first then delete.

vbossica commented 2 years ago

@ArthurMa1978 correct.

The delete method you're listing are for workflows, not for a workflow runs, though.

ghost commented 2 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/azure-logicapps-team.

Issue Details
### Library name Microsoft.Azure.Management.Logic ### Please describe the feature. There is an API endpoint to delete a [workflow run](https://docs.microsoft.com/en-us/rest/api/logic/workflow-runs/delete), yet the method is missing in the [IWorkflowRunsOperations methods](https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.management.logic.iworkflowrunsoperations?view=azure-dotnet) Would it be possible to add the missing method? Or am I looking at the wrong place?
Author: vbossica
Assignees: ArthurMa1978
Labels: `Logic App`, `Service Attention`, `Mgmt`, `question`, `needs-team-attention`
Milestone: -
ArthurMa1978 commented 2 years ago

As this is a feature ask, add Service Attention label to let service team answer this question.

ghost commented 2 years ago

Hi @vbossica. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

ghost commented 2 years ago

Hi @vbossica, since you haven’t asked that we “/unresolve” the issue, we’ll close this out. If you believe further discussion is needed, please add a comment “/unresolve” to reopen the issue.

vbossica commented 2 years ago

/unresolve

vbossica commented 2 years ago

The method to delete an individual workflow run has not been added to https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.management.logic.iworkflowrunsoperations?view=azure-dotnet

github-actions[bot] commented 4 months ago

Hi @vbossica, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

ArthurMa1978 commented 3 months ago

Hey @vbossica , thank you for reaching out to us about the Azure SDK for .NET. Unfortunately, this issue is related to the service side and not the SDK side, so we are not able to help you with it. Therefore, we are closing this issue for now. If you need more assistance, please open an Azure support request. We apologize for any inconvenience this may cause you.

We value your feedback and we want to make sure that your problem is solved. If you think that we have misunderstood your issue or closed it incorrectly, please feel free to comment on this thread and reopen the issue. We will be happy to assist you further. Thank you for your understanding and cooperation.