search

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.36k stars 4.79k forks source link

ClientModel: Add constructor to PipelineMessageClassifier that takes status code ranges #27272

Open annelo-msft opened 2 years ago

annelo-msft commented 2 years ago

This is required for https://github.com/Azure/autorest.csharp/issues/2018

Added further details of what's needed for implementation here: https://github.com/Azure/azure-sdk-for-net/issues/27272#issuecomment-2019017873

pallavit commented 9 months ago

@annelo-msft I do not see any hits for CoreResponseClassifier - https://grep.app/search?q=CoreResponseClassifier&filter[repo][0]=Azure/azure-sdk-for-net. Is this still valid?

annelo-msft commented 9 months ago

This was renamed to StatusCodeClassifier before it GA'ed.

github-actions[bot] commented 7 months ago

Hi @annelo-msft, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

annelo-msft commented 6 months ago

We may need this in ClientModel, if the generator provides custom implementations that are considered "end-of-chain" classifiers -- so that ClientModel can provide an implementation of "is retriable" for the last classifier in a composed chain.

Working with @m-nash to understand the requirements from the generator side -- i.e. what TypeSpec API description causes a custom implementation to be needed.

If the implementation works for both ClientModel and Azure.Core, we can address it in both cases.

github-actions[bot] commented 5 months ago

Hi @annelo-msft, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

annelo-msft commented 5 months ago

reopen