Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.4k stars 4.8k forks source link

[FEATURE REQ] Support for Docker image #28068

Closed ThomasPe closed 6 months ago

ThomasPe commented 2 years ago

Library name

Vision.CustomVision.Prediction

Please describe the feature.

We would like to use the Vision.CustomVision.Prediction package to quickly switch between requests against the online & local docker version.

Currently, the SDK sets the BaseUri like this in line 180 of https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/cognitiveservices/Vision.CustomVision.Prediction/src/Generated/CustomVisionPredictionClient.cs:

BaseUri = "{Endpoint}/customvision/v3.1/prediction";

That means this is also not editable from the outside to adjust the route. Unfortunately this path is also not covered by the auto-created docker image that CustomVision.ai lets us download:

# Like the CustomVision.ai Prediction service /image route handles either
#     - octet-stream image file 
#     - a multipart/form-data with files in the imageData parameter
@app.route('/image', methods=['POST'])
@app.route('/<project>/image', methods=['POST'])
@app.route('/<project>/image/nostore', methods=['POST'])
@app.route('/<project>/classify/iterations/<publishedName>/image', methods=['POST'])
@app.route('/<project>/classify/iterations/<publishedName>/image/nostore', methods=['POST'])
@app.route('/<project>/detect/iterations/<publishedName>/image', methods=['POST'])
@app.route('/<project>/detect/iterations/<publishedName>/image/nostore', methods=['POST'])

It would be great if either the docker image was adjusted to route the request correctly that is being created by the SDK or the SDK gives a bit more freedom to the dev to adjust the BaseUrl without hardcoding the version.

azure-sdk commented 2 years ago

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Cognitive Services:0.23910879,Storage:0.21983914,Cognitive - Computer Vision:0.18023653'

ghost commented 2 years ago

Thank you for your feedback. This has been routed to the support team for assistance.

SaurabhSharma-MSFT commented 2 years ago

@ThomasPe We are looking into it and get back to you for any additional information.

SatishBoddu-MSFT commented 2 years ago

Hello @ThomasPe Thanks for reaching out on this topic!

Routing this to service teams' attention!

ghost commented 2 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @areddish, @tburns10.

Issue Details
### Library name Vision.CustomVision.Prediction ### Please describe the feature. We would like to use the Vision.CustomVision.Prediction package to quickly switch between requests against the online & local docker version. Currently, the SDK sets the BaseUri like this in line 180 of https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/cognitiveservices/Vision.CustomVision.Prediction/src/Generated/CustomVisionPredictionClient.cs: ```BaseUri = "{Endpoint}/customvision/v3.1/prediction";``` That means this is also not editable from the outside to adjust the route. Unfortunately this path is also not covered by the auto-created docker image that CustomVision.ai lets us download: ``` # Like the CustomVision.ai Prediction service /image route handles either # - octet-stream image file # - a multipart/form-data with files in the imageData parameter @app.route('/image', methods=['POST']) @app.route('//image', methods=['POST']) @app.route('//image/nostore', methods=['POST']) @app.route('//classify/iterations//image', methods=['POST']) @app.route('//classify/iterations//image/nostore', methods=['POST']) @app.route('//detect/iterations//image', methods=['POST']) @app.route('//detect/iterations//image/nostore', methods=['POST']) ``` It would be great if either the docker image was adjusted to route the request correctly that is being created by the SDK or the SDK gives a bit more freedom to the dev to adjust the BaseUrl without hardcoding the version.
Author: ThomasPe
Assignees: -
Labels: `Service Attention`, `Client`, `customer-reported`, `question`, `feature-request`, `needs-team-attention`, `Cognitive - Custom Vision`
Milestone: -
github-actions[bot] commented 6 months ago

Hi @ThomasPe, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.