[Text Analytics] Revisit Legacy Generator Customizations

[jsquire]

Summary

Because the Text Analytics library supports two REST services as its backend, it makes use of two generated layers - one of which is associated with the legacy Text Analytics REST service. The generated types for the legacy service are intended to be fully internal and should not appear as part of the public API surface for the client library. To control visibility, a set of transforms is configured for the AutoRest generator.

However, some types are not honoring the internal transformation. Of these, there are several enum types used as parameters for request bodies and cannot be designated as partial to allow more fine-grained generator overrides at the code level. Currently, these have been fully shadowed as a custom class to control visibility, which requires that their members be kept in-sync with the service definition manually.

Scope of Work

• Investigate why the configured generator transforms to force internal visibility are not being honored for some parameter-focused types.

• Determine if it is possible to refine the transforms. If so, make adjustments so that all type are generated as internal; remove the manual shadow copies.

Success Criteria

--EITHER--

• Regenerating the legacy service layer emits all types as internal with no manually managed shadow copies of the enumerations needed.

--OR--

• It is determined that it is not possible for generation to produce these types as internal. No changes are made to the source.

• In either case, the existing test suite continues to produce deterministic results and pass reliably.

References and Resources

• [Text Analytics] Legacy Generation and Abstractions

[github-actions[bot]]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @assafi.

[github-actions[bot]]

Hi @jsquire, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.