search

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.47k stars 4.8k forks source link

[FEATURE REQ] Storage extensions should leverage RequestContext.ErrorOptions #29132

Closed lmolkova closed 4 months ago

lmolkova commented 2 years ago

Library name

Microsoft.Azure.WebJobs.Extensions.Storage.*

Please describe the feature.

Template Azure Functions with Storage bindings report a lot of log warnings at startup and in every trigger call for 404 requests. Such logs should probably have info severity.

MicrosoftTeams-image

Tracing calls for Exists that end up with 404 are also represented as failures

image

Once RequestContext.ErrorOptions are implemented in Storage SDKs, WebJob extensions should leverage it to indicate when such errors should have lower log severity and no error on the tracing side.

Related: #21511, #27645, #27792, #26327, #9934, #9908, #8320, and many other including 404/409/412 responses on blob locks, etag checks and exists calls

lmolkova commented 2 years ago

Related:

27792, #26327, #9934, #9908, https://github.com/Azure/azure-functions-host/issues/8320

and many other including 404/409/412 responses on blob locks, etag checks and exists calls

ghost commented 2 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

Issue Details
### Library name Microsoft.Azure.WebJobs.Extensions.Storage.* ### Please describe the feature. Template Azure Functions with Storage bindings report a lot of log warnings at startup and in every trigger call for 404 requests. Such logs should probably have info severity. ![MicrosoftTeams-image](https://user-images.githubusercontent.com/2347409/172234956-769b3ae0-dec6-4870-bd9a-9366a7cee666.png) Tracing calls for Exists that end up with 404 are also represented as failures ![image](https://user-images.githubusercontent.com/2347409/172235475-6374bf15-d529-424d-b9b0-05a4d9169e9c.png) **Once RequestContext.ErrorOptions are implemented in Storage SDKs, WebJob extensions should leverage it to indicate when such errors should have lower log severity and no error on the tracing side.**
Author: lmolkova
Assignees: -
Labels: `Storage`, `Service Attention`, `Client`
Milestone: -
jsquire commented 2 years ago

//cc: @kasobol-msft

kasobol-msft commented 2 years ago

Related: https://github.com/Azure/azure-sdk-for-net/issues/21511 https://github.com/Azure/azure-sdk-for-net/pull/27645

SeanFeldman commented 2 years ago

Just a suggestion: to have a "Related issues" section under the issue description and keep all the related items right there, along with the main description of the problem.

github-actions[bot] commented 5 months ago

Hi @lmolkova, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

github-actions[bot] commented 4 months ago

Hi @lmolkova, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.