search

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.47k stars 4.8k forks source link

Test failed in net - resourcemanager - mgmt - ci due to project reference #31905

Closed Yao725 closed 2 weeks ago

Yao725 commented 2 years ago

In the tests of Azure.ResourceManager.EventHubs, we have a package reference to Azure.ResourceManager.ManagedServiceIdentitie. But our pipeline will take turns using project reference and package reference for tests and EventHubs just happens to belong to the group that used project reference.

Currently we have a PR https://github.com/Azure/azure-sdk-for-net/pull/31887 to upgrade the API version for ManagedServiceIdentitie and it will cause the failure of EventHubs tests because of the API version mismatch in the test recording. Considering that we have a GAed Azure.ResourceManager.ManagedServiceIdentitie, we should probably respect the package reference in test project because instead of using project reference to override the settings.

weshaggard commented 2 years ago

If the package reference works the project reference should work as well otherwise there is likely a breaking change which is exactly why we do this check in CI.

ArthurMa1978 commented 2 years ago

If the package reference works the project reference should work as well otherwise there is likely a breaking change which is exactly why we do this check in CI.

The scenario here is: sdk A need upgrade to new version and have a PR for review, the test of sdk B depends on sdk A, then the ci net - resourcemanage - mgmt - ci will failed when running project reference tests for sdk B because the REST API version in recorded test data is still old but expect new version.

weshaggard commented 2 years ago

Is this only about a test recording mis-match? Seems so based on what I see at https://dev.azure.com/azure-sdk/public/_build/results?buildId=1929795&view=ms.vss-test-web.build-test-results-tab&runId=36123710&resultId=103310&paneView=debug. Is there any reason we need the api-version in the name of the recorded test?

ArthurMa1978 commented 2 years ago

Will fix the tests that will not record the setup steps

github-actions[bot] commented 2 weeks ago

Hi @Yao725, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.