AOAI Inference `model` field and `deploymentId` key

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.

MIT License

5.26k stars 4.61k forks source link

AOAI Inference `model` field and `deploymentId` key #33819

Open jpalvarezl opened 1 year ago

jpalvarezl commented 1 year ago

Library name and version

Azure.AI.OpenAI

Query/Question

What happens when both model and deploymentId are defined? Which value takes precedence?
Evaluate removing model entirely, as it's seemingly duplicating the information provided through deploymentId

Environment

swagger used in the python GA showing model as nullable in line 136
Current definition of Completions
Current definition of Embeddings

jsquire commented 1 year ago

//fyi: @m-nash

m-nash commented 1 year ago

33834 didn't resolve this it just reverted the old behavior back. We still have a confusing situation where I can specify a conflicting model and deploymentId.

It seems like azure openai should translate the deploymentid into the model that is passed to openai and we should not expose this property in our sdk.