search

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.36k stars 4.75k forks source link

Move LoadTesting SDK to DPG + convenience #34584

Open pallavit opened 1 year ago

pallavit commented 1 year ago

LoadTestingService uses the following autorest pattern - https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/loadtestservice/Azure.Developer.LoadTesting/src/AutorestCustomizations which is not a supported scenario.

Given the above we need to move this SDK to convenience layer API and undo the usage of the unsupported pattern.

pallavit commented 1 year ago

@m-nash could you please help me understand what would it take to move to the right pattern?

Should I just add the generation1-convenience-client: true flag in the https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/loadtestservice/Azure.Developer.LoadTesting/src/autorest.md, remove the autorest extensions, regenerate and retrofit or is there more to it?

m-nash commented 1 year ago

I have asked the team to look into what our options are here, but in general if public-clients is false then we will error if someone tries to change the accessibility of a client class via custom code.