search

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.24k stars 4.58k forks source link

Azure.Core: Support for multipart/form-data content types #42674

Open annelo-msft opened 5 months ago

annelo-msft commented 5 months ago

Tracking separately from System.ClientModel scenarios to make sure it is tracked, but the generator implementation should use the same types from ClientModel to do this.

This issue tracks validation that the ClientModel APIs work for Azure clients as well - if modification is needed, it will be to the ClientModel types - e.g. no new types should be added to Azure.Core for this.

annelo-msft commented 5 months ago

Linking to https://github.com/Azure/azure-sdk-for-net/issues/42105

annelo-msft commented 5 months ago

If possible, it would be good to see if we can remove shared source related to this from Azure.Core as well.

annelo-msft commented 5 months ago

The implementation proposal for Azure is here: https://github.com/annelo-msft/azure-sdk-for-net/pull/18

Once the generator removes the dependency on the internal shared source MultipartFormDataContent type, we will remove this from the repo. It is only used currently by the Azure.AI.OpenAI client and Azure.Analytics.Purview Catalog and DataMap libraries. It is not correctly functional for all cases.

annelo-msft commented 2 months ago

Incorporate updates from https://github.com/openai/openai-dotnet/pull/36