search

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.35k stars 4.7k forks source link

[BUG] Azure.ResourceManager.Orbital SDK Issues #43626

Closed thisisdevanshu closed 6 days ago

thisisdevanshu commented 5 months ago

Library name and version

Azure.ResourceManager.Orbital

Describe the bug

We recently discovered 2 issues with the .NET SDK https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/orbital/Azure.ResourceManager.Orbital

  1. EventHubUri is a misnomer, we expected a resource id, but the SDK expects a URI
  2. EndPoint.ipAddress: - ip-address is not nullable in .NET TSDK

Expected behavior

  1. EventHubUri accepts a resource id in the .NET SDK
  2. Endpoint.ipAddress allows null for ip address

Actual behavior

  1. EventHubUri does not accept a resource id in the .NET SDK
  2. Endpoint.ipAddress does not allow null for ip address

Reproduction Steps

  1. Create a contact profile resource with a eventhub resource id
  2. Create a contact profile with null value for Endpoint.ipAddress

Environment

No response

jsquire commented 5 months ago

Thank you for your feedback. Tagging and routing to the team member best able to assist.

ArthurMa1978 commented 5 months ago

Workaround this from sdk side:

  1. Rename it to eventHubId and add attribute "format": "arm-id".
  2. Remove ipAddress out of required azure-rest-api-specs/specification/orbital/resource-manager/Microsoft.Orbital/stable/2022-11-01/orbital.json at main · Azure/azure-rest-api-specs (github.com)
melina5656 commented 4 weeks ago

Hi @thisisdevanshu , We have conducted multiple tests on PUT/subscriptions/<>/resourceGroups/<>/providers/Microsoft. Organizational/contactprofiles/<>? API version=2022-03-01 and found that the current API version does not support null values for the ipAddress property. If the value passed in is null, a RequestFailedException error will be thrown. May I ask if the version you are using is 2022-03-01? And how did you determine that the ipAddress property can be null? Look forward to your reply.

github-actions[bot] commented 4 weeks ago

Hi @thisisdevanshu. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

github-actions[bot] commented 3 weeks ago

Hi @thisisdevanshu, we're sending this friendly reminder because we haven't heard back from you in 7 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!