search

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.35k stars 4.66k forks source link

[BUG] BlobContainerClient.CreateIfNotExists records 409s as failures in distributed traces and logs #45298

Open lmolkova opened 1 month ago

lmolkova commented 1 month ago

Library name

Azure.Storage.Blobs

Please describe the feature.

image

Azure.Core needs a bit of help from the library to understand when specific responses don't indicate a failure and should not be traced/logged as errors.

This can be done using response classifiers similar to this PR https://github.com/Azure/azure-sdk-for-net/pull/33639 for sync and async versions of this method.

github-actions[bot] commented 1 month ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

hallipr commented 1 month ago

This also applies to blob existence checks, e.g. BlobBaseClient.Exists() where the service returns a 404 on a HEAD request when the blob does not exist. In this case, I would not expect to see a failed dependency call in my telemetry.