search

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.37k stars 4.79k forks source link

ServiceTagsListResult POCO has wrong field types #46767

Open kennyvanle opened 2 hours ago

kennyvanle commented 2 hours ago

Type of issue

Code doesn't work

Description

I am trying to deserialize the ServiceTagsListResult object from service tag downloadable files here: aka.ms/servicetags

The POCOs listed in the documentation and in code for the ServiceTagsListResult and the child objects are listing all of the numeric fields as strings. For example:

Image

source code

Image

This is causing an issue when deserializing the IJsonModel object using the following recommended patterns from the azure github sample ModelReaderWriter.md

Image

This is an issue as System.Json.Text won't allow us to convert Numbers -> String without manual converters, but the usage of JsonModelConverter causes all other converters to be ignored so we cannot use a custom converter on top of this.

My request is to update the POCOs with the proper type to match the json objects stored in the service tags.

Page URL

https://learn.microsoft.com/en-us/dotnet/api/azure.resourcemanager.network.models.servicetagslistresult?view=azure-dotnet

Content source URL

https://github.com/Azure/azure-docs-sdk-dotnet/blob/master/xml/Azure.ResourceManager.Network.Models/ServiceTagsListResult.xml

Document Version Independent Id

fdb8b0d7-0fc5-a5c2-8f88-265f19f77e38

Article author

@azure-sdk

Metadata

jsquire commented 2 hours ago

Thank you for your feedback. Tagging and routing to the team member best able to assist.