search

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.56k stars 4.82k forks source link

[Form Recognizer] The authentication method of weekly pipeline seems to have changed. #46944

Open zedy-wj opened 3 weeks ago

zedy-wj commented 3 weeks ago

We are running live Tests against other clouds like US Gov and Azure China Cloud. The goal is to check whether new azure sdk package work with other clouds or not.

Error Description: The authentication method of weekly pipeline seems to have changed again. The previously modified method of using Azure***Msft.json has an error. The error is as follows: Image

What the latest authentication method is?

Pipeline status: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4281458&view=results

Expected behavior: All tests can pass normally.

@kinelski, @benbp for notification.

jsquire commented 3 weeks ago

@zedy-wj : There have been intentional changes to pipeline auth for security initiatives. @weshaggard would be the best person to speak with about it.

weshaggard commented 3 weeks ago

@zedy-wj I just made some suggestions to your PR that will help with some of these.

Can I also ask why you have a 3 year old PR open? Why are these not merged into main? If they were I would have updated these as well.

benbp commented 3 weeks ago

See my comment at https://github.com/Azure/azure-sdk-for-js/pull/16213/files#r1826255473 for guidance on how to update the config now. We have removed a lot of duplicated config with this update.

@jsquire the old draft PR is primarily used as a vehicle for testing the pipelines, however any live testing changes should be merged into main once confirmed to be working.

@zedy-wj how many of the changes in these PRs are not merged into main? Ideally we should be able to close the draft PRs frequently because changes are landing back into the main branch.

zedy-wj commented 3 weeks ago

@zedy-wj how many of the changes in these PRs are not merged into main? Ideally we should be able to close the draft PRs frequently because changes are landing back into the main branch.

@benbp for now, only the changes related to the form recognizer service have not been merged into the main branch. We will open a new draft PR for testing in our regular testing this month.