search

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.49k stars 4.81k forks source link

[BUG] ApplicationGatewayData FirewallPolicy can't be null #47276

Open liorstauber opened 1 day ago

liorstauber commented 1 day ago

Library name and version

Azure.ResourceManager.Network

Describe the bug

As for this PR: https://github.com/Azure/azure-sdk-for-net/pull/27090, it appears that ApplicationGatewayData cannot have the FirewallPolicy parameter set to null. This is valid behavior, as it's acceptable for a sub-resource to not exist. How can we handle this scenario?

relevant applicationGatewaData code - https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/network/Azure.ResourceManager.Network/src/Generated/ApplicationGatewayData.cs Image

Expected behavior

We want to allow FirewallPolicy to be null.

Actual behavior

FirewallPolicy can't be null, it could just have an empty body when policyId = null.

Reproduction Steps

Create applicationGateway with policy and try to remove it (with policy = null). policyId = null won't work as the whole sub-resouce should be null.

Environment

No response

github-actions[bot] commented 1 day ago

Thank you for your feedback. Tagging and routing to the team member best able to assist.