search

Azure / azure-sdk-for-net

This repository is for active development of the Azure SDK for .NET. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/dotnet/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-net.
MIT License
5.26k stars 4.6k forks source link

Does $(RequiredTargetFrameworks) include all frameworks in $(SdkTargetFx)? #5959

Closed chidozieononiwu closed 5 years ago

chidozieononiwu commented 5 years ago

In the process of updating the .Net Repo structure #5213 $(RequiredTargetFrameworks) is used instead of the $(SdkTargetFx) property used in some of the services. Does $(RequiredTargetFrameworks) include all the frameworks specified in $(SdkTargetFx) i.e. net452;net461;netstandard1.4;netstandard2.0

The build process doesn't break. But we need to make sure its building for all the required frameworks.

weshaggard commented 5 years ago

@shahabhijeet It looks like a couple months ago you added net461 and netstandard2.0 to SdkTargetFx with PR https://github.com/Azure/azure-sdk-for-net/pull/5204. I know you want that for all the management plane libraries but for the data-plane libraries that were already in this repo should they also have those additional target frameworks?

@AlexGhiondea I guess this is a question for you as well.

AlexGhiondea commented 5 years ago

This would add more assets into the data plane packages for the additional frameworks, right?

I am also wondering if the resolution rules for the packages during restore will change because there are now more assets. But it might end up not being a real issue.

I wouldn’t add more framework versions to the package right now.

@shahabhijeet what do you think?

weshaggard commented 5 years ago

@shahabhijeet @AlexGhiondea We should make a decision about this pretty soon. I just double checked the eventgrid package we released today and this showed up in the diff. The 3.0.0 package had net452 and netstandard14, and the 3.1.0 package had net461, net452, netstandard2.0, netstandard1.4, but because of the move the 3.2.0 package again only had the net452 and netstandard1.4 build. I don't expect this to really cause any issue beyond perhaps some extra package dependencies but it is something we should fix sooner rather then later.

weshaggard commented 5 years ago

@shahabhijeet and I chatted about this and we think we should add net461 and netstandard2.0 to the list of target frameworks that the track 1 data-plane libraries target.