search

Azure / azure-sdk-for-php

Microsoft Azure SDK for PHP
http://azure.microsoft.com/en-us/develop/php/
Apache License 2.0
415 stars 273 forks source link

Add support to SAS authorization #956

Closed Shaked closed 7 years ago

Shaked commented 7 years ago

This pull request adds support using SAS authorization.

As mentioned in https://github.com/Azure/azure-sdk-for-php/issues/726#issuecomment-334990993 I haven't followed the contribution guidelines but am opening a pull request in case someone wants to help with that.

As far as I understand, Wrap authentication is deprecated so I haven't put effort in changing it to show more correct error messages (for example, I could have split ServiceBusSettings.php so that it will throw the correct error when using the wrong connectionString keys.

Shaked

msftclas commented 7 years ago

CLA assistant check
All CLA requirements met.

azuresdkci commented 7 years ago

Can one of the admins verify this patch?

sergey-shandar commented 7 years ago

@Shaked thank you for the PR.

Shaked commented 7 years ago

@sergey-shandar np. It should be quite easy to support php5.6 and 7.0.

FYI php5.6 is not supported anymore: http://php.net/supported-versions.php (only security updates)

sergey-shandar commented 7 years ago

@Shaked yes, I've seen the table. According to this table, we may consider to drop 5.6 in 2019 :-)

sergey-shandar commented 7 years ago

Closed as a duplicate of https://github.com/Azure/azure-sdk-for-php/pull/958