search

Azure / azure-sdk-for-python

This repository is for active development of the Azure SDK for Python. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/python/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-python.
MIT License
4.59k stars 2.8k forks source link

CustomVision - CustomVisionTrainingClient can not be imported from azure.cognitiveservices.vision.customvision #11504

Closed iMicknl closed 4 years ago

iMicknl commented 4 years ago

Describe the bug azure-cognitiveservices-vision-customvision 2.0.0 on PyPi mentions:

CustomVisionTrainingClient cannot be imported from `azure.cognitiveservices.vision.customvision.training anymore` (import from `azure.cognitiveservices.vision.customvision` works like before)

To Reproduce Steps to reproduce the behavior: from azure.cognitiveservices.vision.customvision import CustomVisionTrainingClient

ImportError: cannot import name 'CustomVisionTrainingClient'

Importing it from azure.cognitiveservices.vision.customvision.training works.

Expected behavior Importing from azure.cognitiveservices.vision.customvision should work, or it should be updated in the documentation.

Additional context Related to #11503

ghost commented 4 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @dfulcer.

RodgeFu commented 4 years ago

An issue in changelog tool to generate the doc? + @lmazuel to confirm. thanks.

zikalino commented 4 years ago

@RodgeFu this is not an issue with the tool. Currently we use template for general breaking changes and modify it manually to suit particular release (client names etc.). So yes, it's error prone... Perhaps general breaking changes should be automatically generated by changelog tool as well.

The proper string in this case should be:

CustomVisionPredictionClient cannot be imported from azure.cognitiveservices.vision.customvision.prediction .custom_vision_training_client anymore (import from azure.cognitiveservices.vision.customvision .training works like before) I can make additional release to fix the wording.

ghost commented 4 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @areddish, @tburns10.