Azure / azure-sdk-for-python

This repository is for active development of the Azure SDK for Python. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/python/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-python.
MIT License
4.59k stars 2.8k forks source link

Bug bash to find samples for Event Hubs that need to use the latest package #15111

Closed AlexGhiondea closed 3 years ago

AlexGhiondea commented 3 years ago

Update from @ramya-rao-a

Review the .Python samples for Event Hubs in the below locations to find the ones that do not use the latest version of the package. Update this issue with the list of samples that need updating.

Additionally, ensure the samples that live next to the source code for Event Hubst in this repo shows up in Event Hubs Python samples under docs.microsoft.com/samples. This is done by setting up the right metadata. Ensure that these samples are not outdated.

yunhaoling commented 3 years ago
Samples Link Status Notes Action
Azure Event Hubs client library for Python Samples link
Collecting Scheduled Events with Event Hub link
Azure Event Hubs client library samples with persistent checkpointing for Python link
Azure Event Hubs client library samples with persistent checkpointing for Python link this is an async sample, but same title as the sync one, can we improve that?
swathipil commented 3 years ago

Bugs/Typos/Etc.:

SYNC SAMPLES

SYNC PERSTISTENT CHECKPOINTING

ASYNC_SAMPLES

ASYNC PERSTISTENT CHECKPOINTING

MISC

ramya-rao-a commented 3 years ago

Nice find @swathipil

@yunhaoling To your question on sample title, we control that. You can make the change at https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/eventhub/azure-eventhub-checkpointstoreblob-aio/samples#azure-event-hubs-client-library-samples-with-persistent-checkpointing-for-python

@swathipil Please use https://github.com/Azure/azure-sdk-for-python/issues/15114 to track the changes for the issues you listed above.

https://docs.microsoft.com/en-us/samples/azure-samples/virtual-machines-python-scheduled-events-central-logging/virtual-machines-python-scheduled-events-central-logging/ uses the REST APIs to send events. I have another tracking item to consider whether or not we should update it to use the Event Hubs package