[DigitalTwins] azure-mgmt-digitaltwins is missing a dev_requirements.txt file

Azure / azure-sdk-for-python

This repository is for active development of the Azure SDK for Python. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/python/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-python.

MIT License

4.63k stars 2.84k forks source link

[DigitalTwins] azure-mgmt-digitaltwins is missing a dev_requirements.txt file #15789

Closed seankane-msft closed 2 years ago

seankane-msft commented 3 years ago

The azure-mgmt-digitaltwins library is missing the dev_requirements.txt file. Adding this file will fix the nightly CI failures

jsntcy commented 3 years ago

@seankane-msft

Do all SDK packages need dev_requirements.txt?
Why do we need dev_requirements.txt?
We removed dev_requirements.txt for https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration doesn't have dev_requirements.txt because release pipeline failed due to this file.

seankane-msft commented 3 years ago

@jsntcy the dev_requirements.txt file is required to have the nightly pipeline passing. This issue is more concerned about solving the nightly CI issues.

changlong-liu commented 3 years ago

Hi @seankane-msft , may I know do we still need this dev_requirements.txt in pipeline? I see a later pipeline seems OK for current status: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=755229&view=results.

And we don't have test script for this azure-mgmt-digitaltwins package, so we should not need a dev_requirements.txt?

seankane-msft commented 3 years ago

I am not on the Python team anymore, tagging @scbedd for more current information

scbedd commented 3 years ago

@seankane-msft thanks sir, I'll pick up this thread.

@changlong-liu you only require a dev_requirements.txt if there are dependencies used by your test framework that are not defined as package dependencies. For most, this would mean azure-sdk-tools or azure-devtools. For this specific case, it looks like azure-mgmt-digitaltwins doesn't have tests (at least that's the case now), so you don't need a dev_requirements.txt.

IIRC mgmt-digitaltwins got updated recently right? probably why the errors disappeared. I feel like we can close this item.

xiangyan99 commented 2 years ago

Close since azure-mgmt-digitaltwins does not have tests.