search

Azure / azure-sdk-for-python

This repository is for active development of the Azure SDK for Python. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/python/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-python.
MIT License
4.65k stars 2.84k forks source link

Cleanup Python credscan baseline file suppressions #23260

Closed sima-zhu closed 8 months ago

sima-zhu commented 2 years ago
kurtzeborn commented 2 years ago

Assuming since you put it in the CredScan epic (in ZenHub) that this is about cleaning up CredScan errors in the repo. If you intend to have someone on the language team do this cleanup, please reassign/retag as appropriate.

azure-sdk commented 2 years ago

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Service Bus:0.12977357,Recovery Services Backup:0.08083114,Event Hubs:0.030618664'

scbedd commented 1 year ago

@mccoyp already had this resolved, but I am also adding an addition on credscan in #31193, so taking the opportunity to close this issue as well.

mccoyp commented 1 year ago

@mccoyp already had this resolved, but I am also adding an addition on credscan in #31193, so taking the opportunity to close this issue as well.

@scbedd This issue is actually about removing our use of a baseline file to suppress old CredScan warnings: https://github.com/Azure/azure-sdk-for-python/blob/main/eng/python.gdnbaselines

That work still needs to be done; I haven't gotten around to it yet. It should be easier now than when this was opened because of our CredScan and recording improvements in the interim

scbedd commented 1 year ago

@scbedd This issue is actually about removing our use of a baseline file to suppress old CredScan warnings: https://github.com/Azure/azure-sdk-for-python/blob/main/eng/python.gdnbaselines That work still needs to be done; I haven't gotten around to it yet. It should be easier now than when this was opened because of our CredScan and recording improvements in the interim

Yeah ok I definitely wouldn't get that from this PR title/body. I'll update it. Thanks @mccoyp

github-actions[bot] commented 8 months ago

Hi @sima-zhu, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.