search

Azure / azure-sdk-for-python

This repository is for active development of the Azure SDK for Python. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/python/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-python.
MIT License
4.63k stars 2.84k forks source link

Add PyPy support #29449

Closed auvipy closed 1 year ago

auvipy commented 1 year ago

Is your feature request related to a problem? Please describe. the package is currently breaking out CI with PyPy to build uamqp in kombu

Describe the solution you'd like testing pypy in the CI will help to add support for it eventually

mccoyp commented 1 year ago

Hi @auvipy, thank you for opening an issue? Could I ask which Python SDK package(s) you're using in your scenario?

auvipy commented 1 year ago

azure-servicebus , and it's uamqp as dependency. for uamqp, azure servicebus is failing to build in pypy in the CI related commits https://github.com/celery/kombu/commit/91f6b27446fdcb0bbb477af38a463124cdc6cb49 passes with cpython only and https://github.com/celery/kombu/commit/b310e4f8ebc9615e9710f730acdf3943b963c1ef fails

mccoyp commented 1 year ago

Thank you for the added details! I'll tag some folks who should be able to help, and we'll get back to you as soon as possible.

kashifkhan commented 1 year ago

Hi @auvipy, we don't have any plans to add in support for uamqp in pypy (as its in cython). My team is currently working on a pure python implementation of the AMQP library to replace that, which will help y'all test against pypy. Beta 1 for the Service Bus library using that library is already available at pypi here. This library will be our focus going forward and is already in GA for event hub.

Depending on the usage of the client, perhaps the beta version will work for yall ?

auvipy commented 1 year ago

I already made the CI work with cpython only. I'm not sure how many will use it with pypy so not a big issue for now from my end.

kashifkhan commented 1 year ago

@auvipy would you be interested in the beta ? Its all in python ( uamqp dependency is made optional ) and depending on how yall use it can an option

auvipy commented 1 year ago

beta can be tried, it is https://pypi.org/project/azure-servicebus/7.9.0b1/ right?

kashifkhan commented 1 year ago

Yes @auvipy that's the one. Let us know if we can help you out with it or something crops up. It's feature complete 😃

ghost commented 1 year ago

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

auvipy commented 1 year ago

I'm testing this https://github.com/celery/kombu/pull/1682

kashifkhan commented 1 year ago

@auvipy just checking in to see how things are going with the beta?

auvipy commented 1 year ago

with beta the CI was green. but after the stable release it was failing again showing uamp failures. so I put cpython only in the ci with latest release and CI is green

kashifkhan commented 1 year ago

@auvipy do you happen to have the failure messages with you ? That version of the beta should not have relied on uamqp at all , so would definitely want to investigate if something slipped by.

github-actions[bot] commented 1 year ago

Hi @auvipy. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

github-actions[bot] commented 1 year ago

Hi @auvipy, we're sending this friendly reminder because we haven't heard back from you in 7 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!