search

Azure / azure-sdk-for-python

This repository is for active development of the Azure SDK for Python. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/python/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-python.
MIT License
4.56k stars 2.79k forks source link

Datastore parameter not passed when invoking batch endpoint with local file. #34316

Open fimselamse opened 7 months ago

fimselamse commented 7 months ago

https://github.com/Azure/azure-sdk-for-python/blob/ba70c6a13d8f531a6783d1139120780c357450d2/sdk/ml/azure-ai-ml/azure/ai/ml/operations/_batch_endpoint_operations.py#L511C1-L515C18

The datastore parameter is never passed from the Input dict when invoking a batch endpoint with a local file. Instead it just defaults to the default datastore 'workspaceblobstorage'

fimselamse commented 7 months ago

I have also created an issue on microsoft learn: https://learn.microsoft.com/en-us/answers/questions/1532252/specifying-datastore-parameter-for-input-when-invo

pvaneck commented 7 months ago

Hey, thanks for the feedback. @azureml-github, can someone take a look?

github-actions[bot] commented 7 months ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/azure-ml-sdk @azureml-github.

github-actions[bot] commented 7 months ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/azure-ml-sdk @azureml-github.

thomasfrederikhoeck commented 4 days ago

@pvaneck @TajiHarrisMicrosoft Hi, any progress on this? :-)

pvaneck commented 2 days ago

Sorry, I'm not familiar with the codebase for this package, but the fix looks simple enough.

@azureml-github, Any reason not to propagate any user-supplied datastore name like in JobOperations? It appears similar logic can be applied to BatchEndpointOperations.