search

Azure / azure-sdk-for-python

This repository is for active development of the Azure SDK for Python. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/python/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-python.
MIT License
4.64k stars 2.84k forks source link

/azure-ai-translation-text/samples Needs Review #34565

Open Shanesan opened 9 months ago

Shanesan commented 9 months ago

Describe the bug A clear and concise description of what the bug is.

The readme.md file conflicts in information vs all the files in the samples folder.

Example: Readme.md includes the text_translator = TextTranslationClient(credential, endpoint=endpoint)

while samples/sample_text_translation_break_sentence.py contains

import sample_text_translation_client text_translator = sample_text_translation_client.create_text_translation_client_with_credential()

of which import sample_text_translation_client does not exist as a module in any azure-ai packages.

To Reproduce Steps to reproduce the behavior:

  1. See the following examples and compare to the readme.md:

Expected behavior A clear and concise description of what you expected to happen. It's expected that the readme.md file matches the examples within the folder, and the include modules exist. ModuleNotFoundError: No module named 'sample_text_translation_client'

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

At the very least sample_text_translation_client as a module must be removed from all examples and the proper one implemented.

xiangyan99 commented 9 months ago

Thanks for the feedback, we’ll investigate asap.

github-actions[bot] commented 6 months ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @swmachan.