search

Azure / azure-sdk-for-python

This repository is for active development of the Azure SDK for Python. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/python/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-python.
MIT License
4.53k stars 2.76k forks source link

Typo on Bash code snippet #37076

Closed biggernaaz closed 3 days ago

biggernaaz commented 2 weeks ago

Under the "Create a resource group and Azure Container Registry" sub heading in Step 3:

ACR_PASSWORD=$(az acr credential show \ --resource-group web-app-simple-rg \ --name webappacr123 \ --query "passwords[?name == 'password'].value" \ --output tsv)

should be

$ACR_PASSWORD=(az acr credential show \ --resource-group web-app-simple-rg \ --name webappacr123 \ --query "passwords[?name == 'password'].value" \ --output tsv)

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

github-actions[bot] commented 2 weeks ago

Thank you for your feedback. Tagging and routing to the team member best able to assist.

kristapratico commented 2 weeks ago

@biggernaaz can you share a link for where you see this typo? I can't find it. Thanks!

github-actions[bot] commented 2 weeks ago

Hi @biggernaaz. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

biggernaaz commented 2 weeks ago

@biggernaaz can you share a link for where you see this typo? I can't find it. Thanks!

Hi @kristapratico - https://learn.microsoft.com/en-us/azure/developer/python/tutorial-containerize-simple-web-app-for-app-service?tabs=web-app-flask

In this code snippet the $ needs to be in front of "ACR_PASSWORD=" I believe.

ACR_PASSWORD=$(az acr credential show \ --resource-group web-app-simple-rg \ --name webappacr123 \ --query "passwords[?name == 'password'].value" \ --output tsv)

Corrected version: $ACR_PASSWORD=(az acr credential show \ --resource-group web-app-simple-rg \ --name webappacr123 \ --query "passwords[?name == 'password'].value" \ --output tsv)

YalinLi0312 commented 3 days ago

Hi @biggernaaz , thanks for your feedback! Our doc team is working on it, I'll update here when the snippet is updated.

YalinLi0312 commented 3 days ago

@biggernaaz We've merged the fix in our end, the portal content would get updated soon.

biggernaaz commented 3 days ago

@biggernaaz We've merged the fix in our end, the portal content would get updated soon.

You're very welcome @YalinLi0312. Thanks for the heads-up.