[breaking change detector] fake breaking report - Githubissues

Azure / azure-sdk-for-python

This repository is for active development of the Azure SDK for Python. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/python/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-python.

MIT License

4.63k stars 2.84k forks source link

[breaking change detector] fake breaking report #37513

Closed msyyc closed 3 weeks ago

msyyc commented 1 month ago

For https://github.com/Azure/azure-sdk-for-python/pull/37101/files#diff-305c23c901389ecd04810715b4aabde38dd61be024cdf58b6bde5ead8841e85b, there are many breaking items about system_data:

Actually they are fake report. For example, Application is inherited from Resource:

In previous SDK, Resource doesn't have system_data and it is defined directly in Application: https://github.com/Azure/azure-sdk-for-python/blob/34a03ee1636b7f9b98b2f96a9cfeda9631dc0dbb/sdk/desktopvirtualization/azure-mgmt-desktopvirtualization/azure/mgmt/desktopvirtualization/models/_models_py3.py#L306
In current SDK, Resource already has system_data and Application could call super().__init__ to have it: https://github.com/Azure/azure-sdk-for-python/blob/f8c9b7d6f659c6d1a286cbdacf04bb7a00b1cdf9/sdk/desktopvirtualization/azure-mgmt-desktopvirtualization/azure/mgmt/desktopvirtualization/models/_models_py3.py#L168

catalinaperalta commented 1 month ago

Looking into this one, I'll let you know what I find