search

Azure / azure-sdk-for-python

This repository is for active development of the Azure SDK for Python. For consumers of the SDK we recommend visiting our public developer docs at https://learn.microsoft.com/python/azure/ or our versioned developer docs at https://azure.github.io/azure-sdk-for-python.
MIT License
4.63k stars 2.84k forks source link

Azure AI Inference: remove @distributed_trace(_async) from chat completion operations #37729

Open lmolkova opened 1 month ago

lmolkova commented 1 month ago

Chat completion operations are being instrumented in https://github.com/Azure/azure-sdk-for-python/pull/36890 .

Along with https://github.com/Azure/azure-sdk-for-python/blob/c0a71880f091802a7b5f6e530a4ecec30c339abb/sdk/ai/azure-ai-inference/azure/ai/inference/aio/_patch.py#L440 they result in redundant span recorded by @distributed_trace annotation.

image

We need to make sure we don't double-instrument chat completion calls (and others what we might instrument in the future).

github-actions[bot] commented 1 month ago

Thank you for your feedback. Tagging and routing to the team member best able to assist.