search

Azure / azure-sdk-for-rust

This repository is for active development of the *unofficial* Azure SDK for Rust. This repository is *not* supported by the Azure SDK team.
MIT License
692 stars 237 forks source link

fix hmac features related to docs.rs build failures #1513

Closed demoray closed 9 months ago

johnbatty commented 9 months ago

Looks good to me.

I guess one question is whether we could add something to the CI pipeline or publish process to test docs generation. This might well be too much overhead for the CI pipeline to run on every build, so might be better handled as a pre-publish job. Is the current publish process scripted?

demoray commented 9 months ago

We build documentation as part of CICD.

https://github.com/Azure/azure-sdk-for-rust/blob/7273f1156f8114361f2cb3442f55bc2bcaa6d32c/eng/scripts/code_style.sh#L16

Alas, this does not use the docs.rs build containers, which makes use of package.metadata.docs.rs as part of the build process.