Azure / azure-sdk-for-sap-odata

This repository serves as foundation to power SAP OData SDK development for .NET
MIT License
7 stars 3 forks source link

[FEATURE] Build targets do not consider ARM based architectures #6

Closed lechnerc77 closed 1 year ago

lechnerc77 commented 1 year ago

Is your feature request related to a problem? Please describe.

The build targets defined in build.targets do not consider ARM-based architectures. This especially excludes user of Apple Silicon (M1, M2 based machines).

Describe the solution you'd like

Enhance the build matrix to consider ARM64-based systems

Describe alternatives you've considered

I do not see any alternative paths.

Additional context

n.a.

WillEastbury commented 1 year ago

This is simply adding the line for the supported net60 target to the targets file. This should be easy enough. I'm sure it was there before so not entirely sure where it's gone.

WillEastbury commented 1 year ago

The supported .net RIDs to add to the target file can be found here. Note that this will extend the build time for each added target. https://learn.microsoft.com/en-us/dotnet/core/rid-catalog#using-rids

felihong commented 1 year ago

If I understood correctly, for ARM users this is done by adding e.g. osx.13-arm64 in build.targets, then compile using ./publishtobinariesfolder.cmd? Which I can't directly run on Mac?

Seems like we need a bash/shell version of the automation? Or pre-build binary for ARM users.

WillEastbury commented 1 year ago

The idea is that the publishtobinaries.cmd file will build all of the targets in the build file and we check them in so there will be a prebuilt ARM binary in the zip file. 😊

felihong commented 1 year ago

Update with pull request #29

MartinPankraz commented 1 year ago

@lechnerc77 were you looking for osx.13-arm64 or ios-arm64 when you mentioned apple devices?

https://learn.microsoft.com/en-us/dotnet/core/rid-catalog#using-rids

lechnerc77 commented 1 year ago

I assume osx.13-arm64 is the right choice as I would target Mac/MacBooks and not iOS devices (although iPad Pro might be used, but more an edge case imho)

WillEastbury commented 1 year ago

Why not add both? It's only a build target - we can generate both for a single change.