Azure / azure-sdk-korean

Korean explanation and related materials to navigate Azure SDK parent and child repositories
https://azure.github.io/azure-sdk-korean/
MIT License
34 stars 59 forks source link

Translate README.md into KR #141

Closed unki11 closed 1 year ago

unki11 commented 1 year ago

Translate README.md 기여하기 (Contributing) 부분 한글화

ianychoi commented 1 year ago

Thank you for the PR but I can now say that this is intentional because README.md file can be seen also to non-Korean readers. Maybe for this, keeping both English and Korean parts would be better - would you revise it?

unki11 commented 1 year ago

I think the same. thank you

unki11 commented 1 year ago

@microsoft-github-policy-service agree

unki11 commented 1 year ago

@ianychoi 리뷰 감사합니다. 모든 수정사항 반영했습니다.

ianychoi commented 1 year ago

Author

Almost done! I see that this comment has not been addressed - would you double-check?

"Also translation of contributions and contributor needs to be concise - so, please change "기부자"."

ianychoi commented 1 year ago

Thank you! Approving now