Update PSBoundParameters later to make sure we pick up all changes

Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.

MIT License

110 stars 174 forks source link

Update PSBoundParameters later to make sure we pick up all changes #1177

Open heaths opened 3 years ago

heaths commented 3 years ago

We need to update PSBoundParameters here.
And ProvisionerApplicationSecret and TenantId
TestApplicationOid is also updated later in the script.
BaseName is updated later as well.
As well as ResourceGroupName

Originally posted by @pakrym in https://github.com/Azure/azure-sdk-tools/pull/1175#r518910453

heaths commented 3 years ago

@benbp I'll let you get your work in first so this doesn't conflict. This issue shouldn't regress anything since people clearly weren't using "newly" added parameters, or they'd have been broken before. And my change that needs the $BaseName isn't going in until 1) the Az module is updated on agents, or 2) we have a story for prereq'ing newer Az modules (e.g. az.keyvault@3.0.0).

/cc @weshaggard @pakrym

pakrym commented 3 years ago

@heaths, were you intending to close this?

heaths commented 3 years ago

Yes, I fixed it with the latest changes we sync'd. I still kept updating of $PSBoundParameters closer to where we set/overwrote the variables because I still think it's more tenable than trying to remember all the variables we need to overwrite in $PSBoundParameters later, but the intent of this bug was addressed (i.e. I missed at least $BaseName).

pakrym commented 3 years ago

I don't think so, there a few that are listed in the issue that are not updated.

heaths commented 3 years ago

I see: https://github.com/Azure/azure-sdk-tools/pull/1175/files#r518911288